-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly set kind version when running tests in CI #1864
Explicitly set kind version when running tests in CI #1864
Conversation
48d4c28
to
968c1ff
Compare
3f30cdd
to
542657b
Compare
8590a63
to
551f3af
Compare
551f3af
to
ea1b9cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one thought on how to make this a bit cleaner without env vars.
env: | ||
CURRENT_KIND_VERSION: 0.20.0 | ||
LEGACY_KIND_VERSION: 0.17.0 # for K8s versions latest kind doesn't support anymore | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of adding these to the environment like this, we could use the matrix.include functionality of github actions. https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#expanding-or-adding-matrix-configurations
This would let us specify exactly KIND version each kube version should be using.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered doing that, but given that:
- There would only ever be two kind versions
- There's less duplication this way, you only change the kind version in one place if you want to upgrade
I decided to do it this way. I don't have a strong opinion on it though, the matrix approach is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix for the CI 🥳
LGTM, but @jaronoff97 has a good comment :)
@swiatekm-sumo should be a similar fix applied to a local setup of kind? |
I think so, but I didn't want to hold this PR up with even more changes. We should treat kind (and kuttl as well) the same way as we treat other local tools - have a make target that installs them to |
I view this PR as a temporary solution until we drop 1.19 (and other old versions) entirely. I'm in favor of getting this merged to unblock other work and then quickly bumping our min k8s version. |
I am merging this to fix the CI, additional fixes can be submitted in follow up PRs |
@TylerHelmuth why do you see this as a temporary solution? |
@pavolloffay I see the permanent solution to be bumping our minimum supported k8s version which I expect to correlate with being able to use a single kind version. |
…1864) * Upgrade kuttl to 0.15.0 * Update kind images for kind 0.20.0 * Use older kind version for older k8s versions
Up until now we depended on the
kind
version shipped by Github, which opened us up to unexpected breakage whenever they upgraded. This has happened recently with an upgrade from0.19.0
to0.20.0
.This change: