[chore] Fix daemonset-features E2E test for OpenShift #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iblancasa
changed the title
pavolloffay
reviewed
Feb 1, 2023
| @@ -0,0 +1,22 @@ | |||
| kind: SecurityContextConstraints | |||
There was a problem hiding this comment.
It's similar to what jaeger-operator does https://github.com/jaegertracing/jaeger-operator/blob/dcb7d7f4bec09ab74b17cac799c3502c6b314158/examples/openshift/hostport-scc-daemonset.yaml
There was a problem hiding this comment.
Yes. I copied, pasted and adapted.
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
iblancasa
force-pushed
the
fix-daemonset-ocp
branch
from
c05a8ec
to
16467ec
Compare
pavolloffay
approved these changes
Feb 1, 2023
This was referenced Feb 2, 2023
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Israel Blancas iblancasa@gmail.com
Fixes #1353