Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve bug where TA doesn't allocate all targets #1039

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

jaronoff97
Copy link
Contributor

@jaronoff97 jaronoff97 commented Aug 16, 2022

This PR addresses and closes #1037 by introducing a new hashing function that ensure no collisions between targets based on the target's label set. This also introduces a small change that scopes the target items list to be private within the allocator and a new getter to expose that to other packages. A new test was added as well to verify that this change works as expected.

@jaronoff97 jaronoff97 marked this pull request as ready for review August 17, 2022 19:45
@jaronoff97 jaronoff97 requested a review from a team August 17, 2022 19:45
@jaronoff97 jaronoff97 changed the title [draft] Resolve bug where TA doesn't allocate all targets Resolve bug where TA doesn't allocate all targets Aug 17, 2022
@pavolloffay pavolloffay merged commit 5021ca7 into open-telemetry:main Aug 18, 2022
@jaronoff97 jaronoff97 deleted the target-issues branch August 18, 2022 15:26
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
* Resolve bug where TA doesn't allocate all targets

* Cleanup cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Target Allocator not allocating all available targets
3 participants