Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target allocator never becomes ready if only Prometheus CRs are enabled, and there aren't any defined #2903

Closed
swiatekm opened this issue Apr 27, 2024 · 0 comments · Fixed by #2883
Labels
bug Something isn't working needs triage

Comments

@swiatekm
Copy link
Contributor

swiatekm commented Apr 27, 2024

Component(s)

target allocator

What happened?

Description

If there aren't any static scrape configs defined, Prometheus CR is enabled, but there aren't any CRs defined in the cluster, the target allocator never generates any targets, and its readiness endpoint never returns a positive response.

There's also a related problem, where if the target allocator gets an empty scrape configs array, it will immediately become ready even if it should've waited for targets from Prometheus CRs instead.

Kubernetes Version

1.29

Operator version

0.98.0

Collector version

0.98.0

Environment information

No response

Log output

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant