Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for observability.metrics.enableMetrics truncated #2561

Closed
reknih opened this issue Jan 24, 2024 · 1 comment · Fixed by #2563
Closed

Documentation for observability.metrics.enableMetrics truncated #2561

reknih opened this issue Jan 24, 2024 · 1 comment · Fixed by #2563
Labels
bug Something isn't working needs triage

Comments

@reknih
Copy link

reknih commented Jan 24, 2024

Component(s)

operator, collector

What happened?

I am currently trying to wrap my head around how to let the OpenTelemetry Collector expose a ServiceMonitor. While doing so, I checked the API docs for the Collector CRD. In there, it contains the following description of the enableMetrics key:

EnableMetrics specifies if ServiceMonitor or PodMonitor(for sidecar mode) should be created for the service managed by the OpenTelemetry Operator. The operator.observability.

This description is obviously truncated. The issue apparently was introduced in PR #1983.

It would be great if the full docs entry could be added back as the instruction to enable the operator.observability.prometheus feature gate seems pretty vital to make use of this key.

Tangent: I'd really appreciate more thorough docs somewhere on how to set up the OTel Collector with its Prometheus exporter and a Service/PodMonitor!

Kubernetes Version

1.27.7

Operator version

v0.92.1

Collector version

v0.92.0

Environment information

Environment

Microsoft AKS

Log output

No response

Additional context

No response

@reknih reknih added bug Something isn't working needs triage labels Jan 24, 2024
@iblancasa
Copy link
Contributor

iblancasa commented Jan 24, 2024

Tangent: I'd really appreciate more thorough docs somewhere on how to set up the OTel Collector with its Prometheus exporter and a Service/PodMonitor!

When the feature gate is enabled and enableMetrics is true, the ServiceMonitor is created. You can check the E2E test to see an example configuration:

I'm checking the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants