Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use k8s 1.28 native sidecar for OTEL collector sidecar mode #2376

Closed
pavolloffay opened this issue Nov 20, 2023 · 5 comments · Fixed by #2801
Closed

Use k8s 1.28 native sidecar for OTEL collector sidecar mode #2376

pavolloffay opened this issue Nov 20, 2023 · 5 comments · Fixed by #2801
Labels
area:collector Issues for deploying collector enhancement New feature or request help wanted Extra attention is needed

Comments

@pavolloffay
Copy link
Member

Component(s)

collector

Is your feature request related to a problem? Please describe.

The k8s 1.28 introduced "native sidecar" mode (init-container with restartPolicy: Always) https://kubernetes.io/blog/2023/08/25/native-sidecar-containers/.

The approach makes sure the sidecar starts/finishes before the application.

Describe the solution you'd like

Use the native sidecar for collector sidecar on k8s 1.28 and above.

Describe alternatives you've considered

No response

Additional context

No response

@pavolloffay pavolloffay added enhancement New feature or request needs triage area:collector Issues for deploying collector help wanted Extra attention is needed and removed needs triage labels Nov 20, 2023
@frzifus
Copy link
Member

frzifus commented Nov 23, 2023

I would like to give that a try.

@angelokurtis
Copy link
Contributor

Hey @frzifus, are you currently working on this task? If not, I'd be interested in contributing to it.

@im-aIex
Copy link

im-aIex commented Sep 17, 2024

Any update on getting this support added? Or any known workarounds to get the new restartPolicy: Always included in the meantime?

@jasonious
Copy link

We are running into this while using gcsfuse annotation which creates a native sidecar, and then the pods can't be terminated. Any estimated timelines for when/if the solution will be merged in? It appears to not have any movement on it for a few months.

@frzifus
Copy link
Member

frzifus commented Oct 10, 2024

Hey, I will try to get this ready on the weekend. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:collector Issues for deploying collector enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants