Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[autoinstrumentation, collector] Improve Auto Instrumentation interaction with Collector Daemonset #2180

Open
2 of 4 tasks
TylerHelmuth opened this issue Sep 29, 2023 · 1 comment
Labels
area:auto-instrumentation Issues for auto-instrumentation area:collector Issues for deploying collector enhancement New feature or request

Comments

@TylerHelmuth
Copy link
Member

TylerHelmuth commented Sep 29, 2023

While doing some investigations with Auto Instrumentation injection and the OpenTelemetryCollector as a daemonset I found some improvements I think we should make to improve the experience.

  • Allow the daemonset Collector to use hostPort so that hostNetwork is not required. This slightly reduces the security impact, reduces required configuration for the user who wants to connect using NODE IP, and aligns with the helm chart's default daemonset instance.
  • Create some documentation about how Auto Instrumentaiton instances should connect to different deployment patterns. I think this should be on the docs site and linked to from our README.
  • Add node_ip via the downward API automatically to the auto instrumentation injected env vars. We already inject Node name so including node IP shouldn't be an issue. Doing this automatically allows users to reference the value without having to define it themselves.
  • Assist with connecting to a collector. Instead of requiring the user to specify the endpoint, provide some more user-friendly options that leverage the Operator to do some setup. Some ideas:
    • Allow the user to specify the name of a collector to export to. The Operator will validate that it exists and then setup the endpoint (idea from @jaronoff97)
    • Allow the user to specify they want to connect to a daemonset instance of the collector. The Operator will validate that it exists and setup the endpoint.
@TylerHelmuth TylerHelmuth added area:collector Issues for deploying collector area:auto-instrumentation Issues for auto-instrumentation enhancement New feature or request labels Sep 29, 2023
@jaronoff97
Copy link
Contributor

As part of this, we should also enable setting the internalTrafficPolicy which i believe would be the cleanest implementation as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:auto-instrumentation Issues for auto-instrumentation area:collector Issues for deploying collector enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants