Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestSmartCollectorReassignment is flaky #1291

Closed
kevinearls opened this issue Nov 30, 2022 · 3 comments · Fixed by #2527
Closed

TestSmartCollectorReassignment is flaky #1291

kevinearls opened this issue Nov 30, 2022 · 3 comments · Fixed by #2527
Labels
area:target-allocator Issues for target-allocator

Comments

@kevinearls
Copy link
Member

TestSmartCollectorReassignment in cmd/otel-allocator/allocation/least_weighted_test.go fails frequently. I will add a t.skip() to prevent it from breaking CI

@secustor secustor added the area:target-allocator Issues for target-allocator label Nov 30, 2022
@secustor
Copy link
Member

Fore reference, the PR which introduced the skip: #1233

@swiatekm
Copy link
Contributor

This test was flaky because the behaviour it was checking wasn't what the strategy actually does. The least-weighted strategy is not stable - it's not guaranteed that if you allocate using the same sets of Collectors and Targets, you'll always get the same allocation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:target-allocator Issues for target-allocator
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants