Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log errors are created if we try to reconcile while a namespace is being deleted #1219

Closed
kevinearls opened this issue Nov 3, 2022 · 2 comments · Fixed by #1233
Closed
Labels
area:collector Issues for deploying collector help wanted Extra attention is needed

Comments

@kevinearls
Copy link
Member

This may only apply to kuttl tests, but sometimes we generate a lot of errors (like the one below) in the logs if the reconciler runs while a namespace is being deleted. It would be nice to not produce these

{"level":"error","ts":"2022-11-03T16:14:56.603485502Z","logger":"controllers.OpenTelemetryCollector","msg":"failed to reconcile config maps","error":"failed to reconcile the expected configmaps: failed to create: configmaps \"simplest-collector\" is forbidden: unable to create new content in namespace kuttl-test-glorious-caribou because it is being terminated","stacktrace":"github.com/open-telemetry/opentelemetry-operator/controllers.(*OpenTelemetryCollectorReconciler).RunTasks\n\t/workspace/controllers/opentelemetrycollector_controller.go:171\ngithub.com/open-telemetry/opentelemetry-operator/controllers.(*OpenTelemetryCollectorReconciler).Reconcile\n\t/workspace/controllers/opentelemetrycollector_controller.go:160\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.0/pkg/internal/controller/controller.go:121\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.0/pkg/internal/controller/controller.go:320\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.0/pkg/internal/controller/controller.go:273\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.0/pkg/internal/controller/controller.go:234"}

@pavolloffay
Copy link
Member

@kevinearls is there any action item for this ticket?

Should the log statement be removed or perhaps changed? Outside of kuttl tests the log seems valuable.

@pavolloffay pavolloffay added area:collector Issues for deploying collector help wanted Extra attention is needed labels Nov 7, 2022
@kevinearls
Copy link
Member Author

@pavolloffay I have a fix for it and will create a PR shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:collector Issues for deploying collector help wanted Extra attention is needed
Projects
None yet
2 participants