-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing create/delete verbs on default instrumentations role #1202
Comments
The link you provided https://github.com/open-telemetry/opentelemetry-operator/blob/main/config/rbac/role.yaml#L138 defines roles for the OTEL operator. The logs in the comment show that your user cannot delete the instrumentation which seems like a different issue. |
@pavolloffay As mentioned above, my user has the exact same roles as the otel operator (+ some others, but not cluster admin). Eg for the actual service-account that the operator is provisioned with:
I don't understand why there is a difference in the roles for the 2 resources. |
Does the operator create any Instrumentations? I don't see why it would need that role (not sure why it has |
The operator does not create/delete any OTEL CRs. |
Makes sense. Thanks. I was thrown off by the fact that the operator can create the collector cr. |
@pavolloffay should create/delete for collectors be dropped from its role? https://github.com/open-telemetry/opentelemetry-operator/blob/main/config/rbac/role.yaml#L150-L151 |
I can do that both here and in the helm repo once we get confirmation. |
We can try, maybe some of the upgrade routines might delete the CR but I am not sure. |
@Allex1 can we close this issue? |
@pavolloffay closing. Thanks |
Deployed operator 0.61.0 on a multi tenant Kubernetes cluster where I am able to use the default roles provided and I cannot create an
otelinst
resource in my ns.I've used the helm chart to deploy the operator in my ns which seems to have the exact same role defined.
This is not the case for the
otelcol
resource which works fine.Am I missing something or should we update the default roles to include these verbs in both the operator and helm repos?
The text was updated successfully, but these errors were encountered: