Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not enable .NET instrumentation if OTEL_DOTNET_AUTO_HOME is already set #1156

Closed
pellared opened this issue Oct 10, 2022 · 1 comment · Fixed by #1177
Closed

Do not enable .NET instrumentation if OTEL_DOTNET_AUTO_HOME is already set #1156

pellared opened this issue Oct 10, 2022 · 1 comment · Fixed by #1177
Labels
area:auto-instrumentation Issues for auto-instrumentation auto-instrumentation:dotnet

Comments

@pellared
Copy link
Member

I think that we should additionally validate that the dotNetOTelAutoHomePath env var was not set in the original container. Otherwise, we cannot auto-instrument the .NET app. If someone set it then it would mean that somebody has already set the .NET AutoInstrumentation in the container.

Originally posted by @pellared in #1141 (comment)
@pellared pellared mentioned this issue Oct 10, 2022
Merged
@avadhut123pisal
Copy link
Contributor

@pavolloffay Can you please assign this issue on my name. I will raise a PR soon.

@avadhut123pisal avadhut123pisal mentioned this issue Oct 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:auto-instrumentation Issues for auto-instrumentation auto-instrumentation:dotnet
Projects
None yet
Milestone
No milestone
3 participants
@pellared @pavolloffay @avadhut123pisal