Use requests for python sample app #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rapphil
requested review from
codeboten,
wangzlei and
NathanielRN
as code owners
Aneurysm9
reviewed
Sep 7, 2022
|
|
||
| s3 = boto3.resource("s3") | ||
|
|
||
| # lambda function | ||
| def lambda_handler(event, context): | ||
|
|
||
| loop = asyncio.get_event_loop() | ||
| loop.run_until_complete(callAioHttp()) | ||
| requests.get("https://www.amazon.com/") |
There was a problem hiding this comment.
This should probably remain httpbin.org.
jeromeinsf
reviewed
Sep 7, 2022
|
|
||
| s3 = boto3.resource("s3") | ||
|
|
||
| # lambda function | ||
| def lambda_handler(event, context): | ||
|
|
||
| loop = asyncio.get_event_loop() | ||
| loop.run_until_complete(callAioHttp()) | ||
| requests.get("http://httpbin.org/") |
Aneurysm9
approved these changes
Sep 7, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aiohttp is causing a regression in the soak tests downstream, causing high CPU usage.
The regression is caused by a bug inserted in this commit: open-telemetry/opentelemetry-python-contrib@e267ebc
The bug was fixed in this commit and will only be available in the next release: open-telemetry/opentelemetry-python-contrib@934af7e
In order to unblock the soak tests, I'm suggesting that we move to use requests instead of aiohttp.