Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding images of all the contributors in this project #944

Merged
merged 4 commits into from
Apr 16, 2020

Conversation

mayurkale22
Copy link
Member

No description provided.

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg :D

@dyladan
Copy link
Member

dyladan commented Apr 7, 2020

How was this generated? Is this something we can try to keep up to date on a monthly basis? New contributors may wonder why their image isn't included. A last-updated timestamp at least may help with that.

@codecov-io
Copy link

codecov-io commented Apr 7, 2020

Codecov Report

Merging #944 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #944   +/-   ##
=======================================
  Coverage   94.75%   94.75%           
=======================================
  Files         248      248           
  Lines       11288    11288           
  Branches     1079     1079           
=======================================
  Hits        10696    10696           
  Misses        592      592           

@mayurkale22
Copy link
Member Author

How was this generated? Is this something we can try to keep up to date on a monthly basis? New contributors may wonder why their image isn't included. A last-updated timestamp at least may help with that.

I used https://contributors-img.web.app/preview tool to generate the url. I think it will keep list up-to-date (not sure how).

@dyladan
Copy link
Member

dyladan commented Apr 7, 2020

Oh I didn't even notice the image was a webapp like that. Very cool

@mayurkale22 mayurkale22 merged commit d71954e into open-telemetry:master Apr 16, 2020
@mayurkale22 mayurkale22 deleted the img branch April 16, 2020 19:15
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants