-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not clear other labelsets when updating metrics #941
fix: do not clear other labelsets when updating metrics #941
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add some unit test for that ?
Codecov Report
@@ Coverage Diff @@
## master #941 +/- ##
==========================================
- Coverage 94.94% 94.94% -0.01%
==========================================
Files 247 248 +1
Lines 11142 11173 +31
Branches 1065 1068 +3
==========================================
+ Hits 10579 10608 +29
- Misses 563 565 +2
|
@obecny @mayurkale22 added tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…g included in release (open-telemetry#941)
Originally reported by @obecny in gitter:
The following code:
Gave the following prometheus export:
Expected:
This was caused by two issues: