Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change loglevel for beta #856

Conversation

OlivierAlbertini
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • changes to LogLevel.INFO instead of LogLevel.DEBUG

closes open-telemetry#578

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea I almost forgot we talked about this.

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
@dyladan
Copy link
Member

dyladan commented Mar 13, 2020

Please update the branch and we can merge

@codecov-io
Copy link

codecov-io commented Mar 13, 2020

Codecov Report

Merging #856 into master will increase coverage by 1.41%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #856      +/-   ##
==========================================
+ Coverage   92.62%   94.04%   +1.41%     
==========================================
  Files         252      253       +1     
  Lines       11104    10997     -107     
  Branches     1064     1059       -5     
==========================================
+ Hits        10285    10342      +57     
+ Misses        819      655     -164     
Impacted Files Coverage Δ
...entelemetry-core/test/common/ConsoleLogger.test.ts 100.00% <ø> (+22.98%) ⬆️
packages/opentelemetry-metrics/src/types.ts 100.00% <ø> (ø)
packages/opentelemetry-tracing/src/config.ts 100.00% <ø> (ø)
...ges/opentelemetry-core/src/common/ConsoleLogger.ts 94.73% <100.00%> (+3.82%) ⬆️
...kages/opentelemetry-plugin-dns/test/utils/utils.ts 33.33% <0.00%> (-26.67%) ⬇️
...ages/opentelemetry-plugin-http/test/utils/utils.ts 33.33% <0.00%> (-26.67%) ⬇️
...ges/opentelemetry-plugin-https/test/utils/utils.ts 33.33% <0.00%> (-26.67%) ⬇️
...ges/opentelemetry-tracing/src/NoopSpanProcessor.ts 50.00% <0.00%> (-10.00%) ⬇️
.../opentelemetry-exporter-collector/src/transform.ts 89.74% <0.00%> (-7.44%) ⬇️
...ckages/opentelemetry-core/src/common/NoopLogger.ts 80.00% <0.00%> (-3.34%) ⬇️
... and 50 more

@OlivierAlbertini OlivierAlbertini added the Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Mar 13, 2020
@mayurkale22 mayurkale22 merged commit d6b2e62 into open-telemetry:master Mar 13, 2020
naseemkullah pushed a commit to naseemkullah/opentelemetry-js that referenced this pull request Jul 24, 2020
As per open-telemetry#856

Signed-off-by: Naseem <naseem@transit.app>
naseemkullah pushed a commit to naseemkullah/opentelemetry-js that referenced this pull request Jul 24, 2020
As per open-telemetry#856

Signed-off-by: Naseem <naseem@transit.app>
naseemkullah pushed a commit to naseemkullah/opentelemetry-js that referenced this pull request Jul 25, 2020
User can now control the log level by means of env var.

Sets default log level to INFO as per open-telemetry#856

Also shares mock environment functions for tests to be used in
ConsoleLogger tests as well as environment tests.

Signed-off-by: Naseem <naseem@transit.app>
naseemkullah pushed a commit to naseemkullah/opentelemetry-js that referenced this pull request Jul 25, 2020
User can now control the log level by means of env var.

Sets default log level to INFO as per open-telemetry#856

Also shares mock environment functions for tests to be used in
ConsoleLogger tests as well as environment tests.

Signed-off-by: Naseem <naseem@transit.app>
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Co-authored-by: Amir Blum <amir@aspecto.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default log level
4 participants