-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: metric observer #828
Conversation
Codecov Report
@@ Coverage Diff @@
## master #828 +/- ##
=========================================
+ Coverage 94.19% 94.2% +0.01%
=========================================
Files 249 250 +1
Lines 10857 10948 +91
Branches 1058 1058
=========================================
+ Hits 10227 10314 +87
- Misses 630 634 +4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some first pass comments, overall nice work!
packages/opentelemetry-exporter-prometheus/test/prometheus.test.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-exporter-prometheus/test/prometheus.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems generally good to me. I'd like to get this merged soon if possible.
"description": "Example of using @opentelemetry/metrics", | ||
"main": "index.js", | ||
"scripts": { | ||
"start:observer": "node metrics/observer.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some reason this is start:observer
instead of just start
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have created metrics example to be a place for other metrics too, so next step when working on documentation and examples should be to add start:counter
, start:measure
* feat: metric observer * chore: update after review * chore: reviews Co-authored-by: Mayur Kale <mayurkale@google.com>
Which problem is this PR solving?
Short description of the changes