-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add typing to propagator carrier #772
Conversation
dyladan
commented
Feb 6, 2020
- Adds typing where there was none before :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for splitting this from original PR.
@@ -407,7 +407,7 @@ export class HttpPlugin extends BasePlugin<Http> { | |||
const span = plugin._startHttpSpan(operationName, spanOptions); | |||
plugin._tracer | |||
.getHttpTextFormat() | |||
.inject(span.context(), Format.HTTP, options.headers); | |||
.inject(span.context(), Format.HTTP, options.headers!); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh, earlier this worked due to unknown
type.
Codecov Report
@@ Coverage Diff @@
## master #772 +/- ##
==========================================
+ Coverage 91.23% 92.37% +1.13%
==========================================
Files 234 134 -100
Lines 10855 4422 -6433
Branches 1023 411 -612
==========================================
- Hits 9904 4085 -5819
+ Misses 951 337 -614
|