Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add instruction for pg-pool plugin #733

Merged
merged 5 commits into from
Jan 28, 2020

Conversation

xiao-lix
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Add usage instruction for pg-pool plugin.

@obecny
Copy link
Member

obecny commented Jan 24, 2020

@xiao-lix I think you should create an example with "new approach" (registry, getTracer, init etc.)

@codecov-io
Copy link

codecov-io commented Jan 24, 2020

Codecov Report

Merging #733 into master will decrease coverage by 1.51%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #733      +/-   ##
==========================================
- Coverage   92.59%   91.07%   -1.52%     
==========================================
  Files         229      225       -4     
  Lines       10306    10456     +150     
  Branches      933      966      +33     
==========================================
- Hits         9543     9523      -20     
- Misses        763      933     +170
Impacted Files Coverage Δ
packages/opentelemetry-core/test/utils/url.test.ts 50% <0%> (-50%) ⬇️
...pentelemetry-core/test/internal/validators.test.ts 50% <0%> (-50%) ⬇️
...elemetry-core/test/trace/spancontext-utils.test.ts 55.55% <0%> (-44.45%) ⬇️
...lemetry-core/test/trace/ProbabilitySampler.test.ts 56.52% <0%> (-43.48%) ⬇️
...s/opentelemetry-core/test/trace/NoopTracer.test.ts 60% <0%> (-40%) ⬇️
...s/opentelemetry-core/test/context/B3Format.test.ts 63.39% <0%> (-36.61%) ⬇️
...ges/opentelemetry-core/test/trace/NoopSpan.test.ts 63.63% <0%> (-36.37%) ⬇️
...s/opentelemetry-core/test/trace/tracestate.test.ts 65.06% <0%> (-34.94%) ⬇️
...ntelemetry-core/test/trace/NoRecordingSpan.test.ts 71.42% <0%> (-28.58%) ⬇️
...ackages/opentelemetry-core/src/platform/node/id.ts 71.42% <0%> (-28.58%) ⬇️
... and 49 more

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just added few comments with regards to copy

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mayurkale22 mayurkale22 added Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) document Documentation-related labels Jan 28, 2020
@dyladan dyladan merged commit 8711f2b into open-telemetry:master Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants