-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add instruction for pg-pool plugin #733
chore: add instruction for pg-pool plugin #733
Conversation
@xiao-lix I think you should create an example with "new approach" (registry, getTracer, init etc.) |
Codecov Report
@@ Coverage Diff @@
## master #733 +/- ##
==========================================
- Coverage 92.59% 91.07% -1.52%
==========================================
Files 229 225 -4
Lines 10306 10456 +150
Branches 933 966 +33
==========================================
- Hits 9543 9523 -20
- Misses 763 933 +170
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just added few comments with regards to copy
packages/opentelemetry-plugin-postgres/opentelemetry-plugin-pg-pool/README.md
Outdated
Show resolved
Hide resolved
packages/opentelemetry-plugin-postgres/opentelemetry-plugin-pg-pool/README.md
Outdated
Show resolved
Hide resolved
packages/opentelemetry-plugin-postgres/opentelemetry-plugin-pg/README.md
Outdated
Show resolved
Hide resolved
packages/opentelemetry-plugin-postgres/opentelemetry-plugin-pg/README.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Which problem is this PR solving?
Short description of the changes