-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: stackdriver trace exporter #648
feat: stackdriver trace exporter #648
Conversation
I created this PR as a draft because I still have some open questions:
|
packages/opentelemetry-exporter-stackdriver-trace/src/external-types.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start, added few initial comments.
packages/opentelemetry-exporter-stackdriver-trace/src/transform.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-exporter-stackdriver-trace/src/transform.ts
Outdated
Show resolved
Hide resolved
Co-Authored-By: Mayur Kale <mayurkale@google.com>
@mayurkale22 is this really xxl with just 20 files changed? How are you differentiating between xl and xxl? |
https://github.com/open-telemetry/opentelemetry-js/labels?utf8=%E2%9C%93&q=size => feel free to suggest or edit the labels or descriptions. |
@draffensperger it would be great, if you can review and approve this one! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
types and transform functions they are almost the same as for ExporterCollector. Seems like this is the same functionality with regards to types and data manipulation. Maybe it should be reused or extended, otherwise I see many duplications here.
packages/opentelemetry-exporter-stackdriver-trace/src/transform.ts
Outdated
Show resolved
Hide resolved
This is because the types for the collector exporter came from opencensus which in turn got its types from stackdriver because they are both google projects. We have to keep them separate because while they are very similar, they are different projects. |
Are you able to add some screenshots to be able to see how the stackdriver spans looks like ? |
I don't have time to do it today. if @mayurkale22 merges this while i'm on vacation I can add it in a separate PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for making it infer the project ID from the credentials when not specified. Had just a few minor suggestions about making it a bit clearer in the dos that service accounts aren't needed when running on GCP. Other than that, looks good!
packages/opentelemetry-exporter-stackdriver-trace/src/external-types.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-exporter-stackdriver-trace/src/external-types.ts
Outdated
Show resolved
Hide resolved
@dyladan Could you please resolve the last round of comments, I think it is good to go after that. |
yes i'll do that today. i've been spending a lot of time on the named tracers spec recently and this got lost in the shuffle |
@mayurkale22 seems like this is probably good to go now whenever you're ready |
ping on that |
…opentelemetry-js into stackdriver-trace
@obecny done |
Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>
Which problem is this PR solving?
Short description of the changes