Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exporter guide #575

Merged
merged 5 commits into from
Dec 2, 2019
Merged

Conversation

mayurkale22
Copy link
Member

Which problem is this PR solving?

  • OpenTelemetry exporters can be contributed by anyone, this guide will provide a means for developers/vendors/users to create their own.

doc/exporter-guide.md Outdated Show resolved Hide resolved
doc/exporter-guide.md Outdated Show resolved Hide resolved
doc/exporter-guide.md Outdated Show resolved Hide resolved
doc/exporter-guide.md Outdated Show resolved Hide resolved
doc/exporter-guide.md Outdated Show resolved Hide resolved
doc/exporter-guide.md Outdated Show resolved Hide resolved
doc/exporter-guide.md Outdated Show resolved Hide resolved
doc/exporter-guide.md Outdated Show resolved Hide resolved
doc/exporter-guide.md Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Nov 26, 2019

Codecov Report

Merging #575 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #575      +/-   ##
==========================================
- Coverage   92.53%   92.46%   -0.08%     
==========================================
  Files         158      155       -3     
  Lines        7999     7868     -131     
  Branches      684      683       -1     
==========================================
- Hits         7402     7275     -127     
+ Misses        597      593       -4
Impacted Files Coverage Δ
...ges/opentelemetry-exporter-zipkin/src/transform.ts 100% <0%> (ø) ⬆️
.../opentelemetry-exporter-zipkin/test/zipkin.test.ts 100% <0%> (ø) ⬆️
...try-node/test/instrumentation/PluginLoader.test.ts 100% <0%> (ø) ⬆️
...telemetry-scope-base/test/NoopScopeManager.test.ts 100% <0%> (ø) ⬆️
...entelemetry-exporter-zipkin/test/transform.test.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-metrics/src/types.ts
...ackages/opentelemetry-exporter-zipkin/src/utils.ts
packages/opentelemetry-node/src/config.ts
...es/opentelemetry-node/src/instrumentation/utils.ts 100% <0%> (+9.52%) ⬆️
...kages/opentelemetry-metrics/test/mocks/Exporter.ts 100% <0%> (+33.33%) ⬆️

doc/exporter-guide.md Outdated Show resolved Hide resolved
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@OlivierAlbertini OlivierAlbertini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mayurkale22 mayurkale22 added Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) and removed Awaiting reviewer feedback labels Dec 2, 2019
@mayurkale22 mayurkale22 merged commit 9297a4d into open-telemetry:master Dec 2, 2019
@mayurkale22 mayurkale22 deleted the exporter-guide branch December 2, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants