Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grpc): use correct supportedVersions #487

Conversation

markwolff
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • Change supportedVersions to be 1.*
  • Move unneeded dependencies to dev dependencies

@mayurkale22 mayurkale22 added the bug Something isn't working label Nov 6, 2019
@codecov-io
Copy link

codecov-io commented Nov 6, 2019

Codecov Report

Merging #487 into master will decrease coverage by 7.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #487      +/-   ##
==========================================
- Coverage   94.86%   87.79%   -7.07%     
==========================================
  Files         136      123      -13     
  Lines        6288     5884     -404     
  Branches      566      555      -11     
==========================================
- Hits         5965     5166     -799     
- Misses        323      718     +395
Impacted Files Coverage Δ
packages/opentelemetry-plugin-grpc/src/grpc.ts 96.23% <100%> (-0.05%) ⬇️
...entelemetry-core/test/common/ConsoleLogger.test.ts 0% <0%> (-100%) ⬇️
...try-core/test/trace/fixtures/test-package/index.js 0% <0%> (-100%) ⬇️
...ges/opentelemetry-core/test/trace/NoopSpan.test.ts 0% <0%> (-100%) ⬇️
...s/opentelemetry-core/test/context/B3Format.test.ts 0% <0%> (-100%) ⬇️
...ntelemetry-core/test/trace/NoRecordingSpan.test.ts 0% <0%> (-100%) ⬇️
...st/trace/fixtures/test-package/foo/bar/internal.js 0% <0%> (-100%) ⬇️
...ackages/opentelemetry-core/src/platform/node/id.ts 0% <0%> (-100%) ⬇️
...pentelemetry-core/src/platform/node/performance.ts 0% <0%> (-100%) ⬇️
...s/opentelemetry-core/test/trace/NoopTracer.test.ts 0% <0%> (-100%) ⬇️
... and 25 more

@mayurkale22 mayurkale22 merged commit b00a2f3 into open-telemetry:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin/gRPC: Incorrect supportedVersion is provided
5 participants