Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release proposal 1.8.0 / 0.34.0 #3388

Closed
wants to merge 1 commit into from

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Nov 7, 2022

1.8.0

💥 Breaking Change

🚀 (Enhancement)

🐛 (Bug Fix)

  • fix(sdk-trace): enforce consistent span durations
    #3327 @dyladan
  • fix(resources): fix EnvDetector throwing errors when attribute values contain spaces
    #3295
  • fix(trace): fix an issue which caused negative span durations in web based spans
    #3359 @dyladan
  • fix(resources): strict OTEL_RESOURCE_ATTRIBUTES baggage octet decoding
    #3341 @legendecas

Experimental 0.34.0

💥 Breaking Change

  • Add semver check to metrics API #3357 @dyladan
    • Previously API versions were only considered compatible if the API was exactly the same

🚀 (Enhancement)

  • feat(metrics-sdk): Add tracing suppresing for Metrics Export #3332 @hectorhdzg
  • feat(instrumentation): implement require-in-the-middle singleton #3161 @mhassan1
  • feat(sdk-node): configure trace exporter with environment variables #3143 @svetlanabrennan
  • feat: enable tree shaking #3329 @pkanal
  • feat(prometheus): serialize resource as target_info gauge #3300 @pichlermarc
  • feat(detectors): add browser detector module #3292 @Abinet18
  • deps: remove unused proto-loader dependencies and update grpc-js and proto-loader versions #3337 @seemk
  • feat(metrics-exporters): configure temporality via environment variable #3305 @pichlermarc

🐛 (Bug Fix)

  • fix(node-sdk): move @opentelemetry/semantic-conventions to dependencies #3283 @mhassan1
  • fix(exporters): do not append trailing '/' when URL contains path #3274 @pichlermarc
  • fix(instrumentation): debug log on no modules defined for instrumentation #3308 @legendecas

📚 (Refine Doc)

  • docs(metrics-exporters): fix wrong exporter const name in example #3270 @pichlermarc

🏠 (Internal)

  • ci(instrumentation-http): remove got devDependency
    #3347 @dyladan
  • deps(instrumentation-http): move sdk-metrics to dev dependencies #3380 @pichlermarc

@dyladan dyladan requested a review from a team November 7, 2022 12:59
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #3388 (5019015) into main (d154066) will decrease coverage by 0.61%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3388      +/-   ##
==========================================
- Coverage   93.24%   92.62%   -0.62%     
==========================================
  Files         247      132     -115     
  Lines        7341     3133    -4208     
  Branches     1509      652     -857     
==========================================
- Hits         6845     2902    -3943     
+ Misses        496      231     -265     
Impacted Files Coverage Δ
api/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...s/opentelemetry-core/src/platform/node/sdk-info.ts 0.00% <0.00%> (-100.00%) ⬇️
...opentelemetry-core/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...pentelemetry-core/src/platform/node/performance.ts 0.00% <0.00%> (-100.00%) ⬇️
.../packages/api-logs/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...lemetry-resources/src/detectors/ProcessDetector.ts 31.81% <0.00%> (-68.19%) ⬇️
...perimental/packages/otlp-exporter-base/src/util.ts 78.94% <0.00%> (-15.79%) ⬇️
...ckages/opentelemetry-exporter-zipkin/src/zipkin.ts 84.48% <0.00%> (-15.52%) ⬇️
...er-metrics-otlp-http/src/OTLPMetricExporterBase.ts 51.21% <0.00%> (-12.20%) ⬇️
...lemetry-resources/src/detectors/BrowserDetector.ts 93.33% <0.00%> (-6.67%) ⬇️
... and 117 more

@SimenB
Copy link
Contributor

SimenB commented Nov 7, 2022

Could this include #3366 as well? 😀 (unless it still has unresolved issues of course)

legendecas
legendecas previously approved these changes Nov 7, 2022
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the releases!

@legendecas
Copy link
Member

Is #3374 included in this release? IIUC, if the API package is not released along with this proposal, #3374 should be excluded from this release as it contains breaking changes on api-metrics package.

@legendecas legendecas dismissed their stale review November 7, 2022 16:38

Questions raised.

@dyladan
Copy link
Member Author

dyladan commented Nov 7, 2022

Yes it is included. There is no really easy way to exclude it except to diverge from main somehow? The other one is the #3357 which adds the semver check to the metrics API. It is not included here because the metrics-api package is gone, but if we bring it back for this release we would need to not include that change. Any suggestion?

@legendecas
Copy link
Member

legendecas commented Nov 7, 2022

There are only three unsettled API metrics spec review issues https://github.com/open-telemetry/opentelemetry-js/issues?q=is%3Aopen+is%3Aissue+milestone%3A%22Metrics+GA%22+label%3Aapi%3Ametrics opened. Would it make sense for us to decide if they can be deferred to unblock the release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants