-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release SDK 1.8.0 / Experimental 0.34.0 with metrics GA #3340
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3340 +/- ##
==========================================
- Coverage 93.77% 93.25% -0.52%
==========================================
Files 45 247 +202
Lines 643 7344 +6701
Branches 102 1511 +1409
==========================================
+ Hits 603 6849 +6246
- Misses 40 495 +455
|
/easycla |
Awesome, super excited about Metrics going v1 :)) |
Converting to draft as it seems my approach must have had some fundamental flaw somewhere and I want to have confidence that the version change is good before making too many people look at this. |
I propose we postpone this release until #3341 is merged. I think it makes sense to wait until |
Do we want to remove the references to this in some Metrics packages's README files? |
Yes we definitely do. I'm holding this right now while we resolve #3368 |
Does this release include the tree shaking change? It's definitely in main but I don't see it in the release description in this PR. |
Yes I just haven't updated the description. I'll update it |
@open-telemetry/javascript-approvers this now contains an API minor version bump with metrics. Please review it so we can release metrics. |
All I am going to let this go for the weekend at least to let people review it and try to release monday if there are a few approvals. Enjoy your weekends. |
Worth noting that we've got comments on the GA interface in the TC review on metric API/SDK: open-telemetry/community#1204 |
Converting back to draft until the API questions are resolved. I'll open another release PR which releases the other packages with important fixes. |
Going to release this in the morning |
I'm not sure what is causing the bootstrap to fail but we obviously can't merge like this |
This graduates the metrics API and SDK to GA. The exporters are still not yet moved. If there are other packages which should be moved comment below with your reasoning. If there are PRs or issues which should block this release, comment below and I will add them to this PR description.
Blocking issues / PRs:
SDK 1.8.0
@opentelemetry/sdk-metrics
has been promoted to stable🚀 (Enhancement)
🐛 (Bug Fix)
#3327 @dyladan
#3295
#3359 @dyladan
#3341 @legendecas
🏠 (Internal)
Experimental 0.34.0
@opentelemetry/sdk-metrics
moved to packages/sdk-metrics@opentelemetry/api-metrics
deprecated and merged into api🚀 (Enhancement)
require-in-the-middle
singleton #3161 @mhassan1🐛 (Bug Fix)
@opentelemetry/semantic-conventions
todependencies
#3283 @mhassan1📚 (Refine Doc)
🏠 (Internal)
#3347 @dyladan