feat(sdk-metrics-base): per metric-reader aggregation #3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
force-pushed
the
metrics-ff/reader-aggregation
branch
4 times, most recently
from
ccc296f
to
a9a058d
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3153 +/- ##
==========================================
- Coverage 93.21% 93.20% -0.02%
==========================================
Files 196 196
Lines 6443 6491 +48
Branches 1363 1370 +7
==========================================
+ Hits 6006 6050 +44
- Misses 437 441 +4
|
legendecas
force-pushed
the
metrics-ff/reader-aggregation
branch
5 times, most recently
from
df29111
to
2c5d368
Compare
pichlermarc
reviewed
Aug 16, 2022
experimental/packages/opentelemetry-exporter-metrics-otlp-http/src/AggregationSelector.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-exporter-metrics-otlp-http/src/AggregationSelector.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics/src/export/MetricExporter.ts
Outdated
Show resolved
Hide resolved
|
Adding this to the milestone since it doesn't have a tracking issue |
legendecas
force-pushed
the
metrics-ff/reader-aggregation
branch
from
fd1830c
to
fabdaf4
Compare
pichlermarc
approved these changes
Aug 29, 2022
…ggregation # Conflicts: # experimental/packages/opentelemetry-sdk-metrics/src/index.ts # experimental/packages/opentelemetry-sdk-metrics/test/state/MeterSharedState.test.ts
|
Conflicts resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Add support for per-metric-reader aggregation support
Short description of the changes
sdk-metrics-base
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#metricreader
The spec requires the SDK to allow constructing a MetricReader with an optional aggregation selector and an optional aggregation temporality selector. These selectors are only applicable to the specific metric reader, and should not cause side effects on other metric readers.
Type of change
How Has This Been Tested?
Checklist: