Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release proposal 1.4.0/0.30.0 #3065

Merged
merged 8 commits into from
Jul 6, 2022
Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jun 29, 2022

1.4.0

🚀 (Enhancement)

  • fix(resources): fix browser compatibility for host and os detectors #3004 @legendecas
  • fix(sdk-trace-base): fix crash on environments without global document #3000 @legendecas

🏠 (Internal)

Experimental 0.30.0

💥 Breaking Change

🚀 (Enhancement)

  • feat(opentelemetry-instrumentation-fetch): optionally ignore network events #3028 @gregolsen
  • feat(http-instrumentation): record exceptions in http instrumentation #3008 @luismiramirez
  • feat(node-sdk): add serviceName config option #2867 @naseemkullah
  • feat(opentelemetry-exporter-prometheus): export PrometheusSerializer #3034 @matschaffer
  • feat(sdk-metrics-base): detect resets on async metrics #2990 @legendecas
    • Added monotonicity support in SumAggregator.
    • Added reset and gaps detection for async metric instruments.
    • Fixed the start time and end time of an exported metric with regarding to resets and gaps.

🐛 (Bug Fix)

  • fix(otlp-transformer): remove type dependency on Long #3022 @legendecas
  • fix(grpc-exporter): use non-normalized URL to determine channel security #3019 @pichlermarc
  • fix(otlp-exporter-base): fix gzip output stream in http otlp export #3046 @mattolson
  • docs(grpc-exporters): remove 'web' as supported from README.md #3070 @pichlermarc

🏠 (Internal)

@dyladan dyladan requested a review from a team June 29, 2022 15:02
@legendecas
Copy link
Member

Looks like the changelog entry for #2990 has been put into the wrong section of v0.29.0.

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #3065 (d24ad5d) into main (474ec86) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3065      +/-   ##
==========================================
- Coverage   93.10%   93.08%   -0.02%     
==========================================
  Files         188      188              
  Lines        6261     6261              
  Branches     1323     1323              
==========================================
- Hits         5829     5828       -1     
- Misses        432      433       +1     
Impacted Files Coverage Δ
...emetry-core/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

@dyladan
Copy link
Member Author

dyladan commented Jun 29, 2022

2990

🤔 must have missed that before. Fixed

@dyladan dyladan closed this Jun 29, 2022
@dyladan dyladan reopened this Jun 29, 2022
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the changelog entry!

@vmarchaud vmarchaud changed the title release proposal 1.3.0/0.30.0 release proposal 1.4.0/0.30.0 Jun 29, 2022
@pichlermarc
Copy link
Member

We'll need to update the compatibility matrix in README.md 🙂

@dyladan dyladan linked an issue Jul 6, 2022 that may be closed by this pull request
@vmarchaud
Copy link
Member

Are we waiting on a specific PR to release ?

@dyladan
Copy link
Member Author

dyladan commented Jul 6, 2022

No just on me to have time since the build takes some time. I'm doing it now

@dyladan dyladan merged commit e39ab88 into open-telemetry:main Jul 6, 2022
@dyladan dyladan deleted the proposal-1.3-0.30 branch July 6, 2022 19:55
@feywind
Copy link

feywind commented Jul 7, 2022

So, I hate to be That Person, but by semantic versioning, deprecating a Node engine shouldn't be a minor. (Even if it's an EOL engine.) It's a breaking change that's going to affect anyone pulling this package in as a ^1 dependency.

@dyladan
Copy link
Member Author

dyladan commented Jul 7, 2022

I hate to be That Person

No problem. Every project gets complaints and we have to hear them somehow.

by semantic versioning, deprecating a Node engine shouldn't be a minor

This was something we discussed for quite a while including talking to spec maintainers and on several SIG calls and was not a decision we took lightly. Deprecating node versions is something we will need to do regularly in the future. We do not want to support EOL versions and node versions expire every year. If we bump the major version each time node is EOL'd, then we will end up having to regularly bump the major version despite not actually changing any interfaces in a breaking way. If you look at the other OTel implementations, you will see they are also doing the same thing (go for example: https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.3.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants