Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk-web): parse url with relative url string #2972

Merged
merged 3 commits into from
May 17, 2022

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented May 16, 2022

Which problem is this PR solving?

Removes redundant implementation of parseUrl in web instrument packages.

Also fixes global environment checks for web-like environments like Deno. However, I still cannot find a proper way to run our test suites with Deno :(.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • parseUrl with relative url

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #2972 (fce2b92) into main (69cced2) will decrease coverage by 1.22%.
The diff coverage is 100.00%.

❗ Current head fce2b92 differs from pull request most recent head a9846e6. Consider uploading reports for the commit a9846e6 to get more accurate results

@@            Coverage Diff             @@
##             main    #2972      +/-   ##
==========================================
- Coverage   92.55%   91.33%   -1.23%     
==========================================
  Files         183      176       -7     
  Lines        6034     5552     -482     
  Branches     1284     1196      -88     
==========================================
- Hits         5585     5071     -514     
- Misses        449      481      +32     
Impacted Files Coverage Δ
packages/opentelemetry-sdk-trace-web/src/utils.ts 65.62% <100.00%> (-29.38%) ⬇️
...lemetry-resources/src/detectors/BrowserDetector.ts 53.33% <0.00%> (-46.67%) ⬇️
...lemetry-resources/src/detectors/ProcessDetector.ts 95.45% <0.00%> (-4.55%) ⬇️
...s/opentelemetry-instrumentation-fetch/src/fetch.ts
...emetry-instrumentation-xml-http-request/src/xhr.ts
...ation-xml-http-request/src/enums/AttributeNames.ts
...ry-context-zone-peer-dep/src/ZoneContextManager.ts
...mentation-xml-http-request/src/enums/EventNames.ts
...es/opentelemetry-context-zone-peer-dep/src/util.ts
... and 1 more

@legendecas legendecas marked this pull request as ready for review May 16, 2022 04:34
@legendecas legendecas requested a review from a team May 16, 2022 04:34
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for working this! 🙂

@legendecas legendecas merged commit 610808d into open-telemetry:main May 17, 2022
@legendecas legendecas deleted the instrument-fetch branch May 17, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parseUrl from sdk-trace-web does not support relative paths anymore
3 participants