fix: pass same context to Sampler and SpanProcessor in root span case #2790
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Currently
Sampler
gets a different context thenSpanProcessor
in caseoption.root
is set totrue
. This is inconsistent and besides that theSpanProcessor
might end up in a wrong conclusion regarding parent span which is not intended.Short description of the changes
If
options.root
is set the behavior is like no parent span is on context.Delete a potential span from context and pass this new context to
onStart()
andshouldSample()
.Type of change
How Has This Been Tested?
Checklist: