test(sdk-trace-base): pin core.hrtime dependencies on timeOrigin #2768
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #2764
Short description of the changes
timeInputToHrTime
in Span constructor callshrTime
, which depends onperformance.timeOrigin
.performance.timeOrigin
isDOMHighResTimeStamp
, a double-precision floating-point number.hrTimeToMilliseconds
rounds the hrTime to milliseconds, which could round up or down.hrTime
returns theperformanceNow
(in the case,0
) +performance.timeOrigin
, hence the result may have a fractional portion and may be round up or down (to 123 or 124).After the change, the test can pass 10 out of 10 (compared to main branch 8/10) locally.
Type of change
Checklist: