-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: target to es2017 in the no-polyfill target #2765
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2765 +/- ##
=======================================
Coverage 93.41% 93.41%
=======================================
Files 159 159
Lines 5450 5450
Branches 1145 1145
=======================================
Hits 5091 5091
Misses 359 359 |
Can this be considered a breaking change? If someone was previously targeting the |
We have not released this yet. So I don't think so. |
edit: looks like I'm wrong. The PR was opened in october but was merged in december and is not released. This is not a breaking change |
@schickling we're working to fix it: #2844. Sorry for the inconvenience. |
Which problem is this PR solving?
This is a follow-up of #2556.
As the original PR claims to fix #2471, unfortunately, the problem is not resolved. The async function was introduced with es2017, so targeting es2015 is not enough and it is still been polyfill-ed. #2556 (comment)
This PR aligns the target with tsconfig.base.json (which is used for Node.js targets). Also renamed the target name as "esnext", so that we can freely upgrade the target to a later version of ECMAScript.
Another problem is that referencing projects with tsconfig suffix like ".all.json" in the root tsconfig project is not supported by the update-ts-references yet. The root tsconfig.json is always being updated during the bootstrap since the update-ts-references is invoked with after-install hook. This can be confusing, for git tracked files were updated during bootstrap of the project. These targets are only needed when publishing, so we don't have to compile them on the root project "compile" script. The pre-publish for each package invokes the "compile" script, which is compiled with the "tsconfig.all.json".
Short description of the changes
Type of change
Checklist: