-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(exporter-jaeger): transform all links to jaeger reference #2731
Merged
vmarchaud
merged 6 commits into
open-telemetry:main
from
blumamir:jaeger-exporter-links
Jan 31, 2022
Merged
fix(exporter-jaeger): transform all links to jaeger reference #2731
vmarchaud
merged 6 commits into
open-telemetry:main
from
blumamir:jaeger-exporter-links
Jan 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2731 +/- ##
==========================================
+ Coverage 92.01% 93.27% +1.26%
==========================================
Files 147 159 +12
Lines 4706 5444 +738
Branches 990 1141 +151
==========================================
+ Hits 4330 5078 +748
+ Misses 376 366 -10
|
blumamir
commented
Jan 24, 2022
srikanthccv
approved these changes
Jan 25, 2022
dyladan
approved these changes
Jan 25, 2022
vmarchaud
approved these changes
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #2718
Exporter jaeger is currently transforming and exporting only links that point to the parent span. This is in contrast to the spec:
I don't know why it was added in the first place, but it looks like a bug.
References from other SDKs:
ruby - transform all links to jaeger references with no filter.
python - same, transform all links regardless of parent releationship
java - the same
Fixes # (issue)
if
that transform only links that point to span's parent. Now all links are transformed and exported to jaeger.Short description of the changes
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
yarn link
ed, the span is shown in jaeger:Checklist: