feat(sdk-metrics-base): document and export basic APIs #2725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2725 +/- ##
==========================================
+ Coverage 93.23% 93.26% +0.03%
==========================================
Files 158 158
Lines 5436 5434 -2
Branches 1141 1141
==========================================
Hits 5068 5068
+ Misses 368 366 -2
|
Flarna
reviewed
Jan 20, 2022
| import { View } from './view/View'; | ||
|
|
||
| /** | ||
| * Supported types of metric instruments. | ||
| * @see https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#instrument |
There was a problem hiding this comment.
maybe better to point to a tag/commit instead main which moves day by day.
applies also to other places.
There was a problem hiding this comment.
Well, like said, the spec is being updated day by day and it has not been released with a "tagged" version yet. I'd remove these links for now.
pichlermarc
approved these changes
Jan 20, 2022
experimental/packages/opentelemetry-sdk-metrics-base/src/export/MetricData.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/export/MetricData.ts
Outdated
Show resolved
Hide resolved
vmarchaud
approved these changes
Jan 23, 2022
dyladan
approved these changes
Jan 25, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Document and export basic public APIs for implementing an exporter.
Type of change
Checklist:
Unit tests have been added