-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk-trace-web): web worker support #2719
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2719 +/- ##
=======================================
Coverage 93.22% 93.23%
=======================================
Files 157 158 +1
Lines 5432 5436 +4
Branches 1141 1141
=======================================
+ Hits 5064 5068 +4
Misses 368 368
|
legendecas
force-pushed
the
karma-worker
branch
from
January 17, 2022 10:00
9e66f92
to
3a244a4
Compare
5 tasks
legendecas
changed the title
test(sdk-trace-web): run sdk tests on web worker
feat(sdk-trace-web): web worker support
Jan 19, 2022
MSNev
approved these changes
Jan 19, 2022
johnbley
approved these changes
Jan 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; thanks for diligently splitting out the window
-specific tests.
Agreed |
dyladan
approved these changes
Jan 20, 2022
vmarchaud
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This is an initial bootstrap on test facilities on web workers. Packages that target web platforms without specific instrumentation on browsing context API should be able to run their test suites on web workers too.
window
references in generic functions in sdk-trace-web.Type of change
How Has This Been Tested?
Basically, we are running the test suites again on a web worker environment with karma. If tests that are not intended to run won web workers, they should be relocated to the
test/window
directory.Checklist: