Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk-metrics-base): bootstrap metrics exemplars #2641

Merged
merged 26 commits into from
Dec 28, 2021

Conversation

srikanthccv
Copy link
Member

Short description of the changes

Part of #2594 . This adds the types, interfaces(ExemplarFilter, ExemplarReservoir) and the built-in sdk implementations.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • npm test

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #2641 (45d86b5) into main (ddede49) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2641      +/-   ##
==========================================
- Coverage   92.53%   92.52%   -0.02%     
==========================================
  Files         144      151       +7     
  Lines        5186     5283      +97     
  Branches     1106     1116      +10     
==========================================
+ Hits         4799     4888      +89     
- Misses        387      395       +8     
Impacted Files Coverage Δ
...trics-base/src/exemplar/WithTraceExemplarFilter.ts 85.71% <0.00%> (ø)
...e/src/exemplar/SimpleFixedSizeExemplarReservoir.ts 76.47% <0.00%> (ø)
...entelemetry-sdk-metrics-base/src/exemplar/index.ts 100.00% <0.00%> (ø)
...cs-base/src/exemplar/AlwaysSampleExemplarFilter.ts 100.00% <0.00%> (ø)
...ics-base/src/exemplar/NeverSampleExemplarFilter.ts 100.00% <0.00%> (ø)
...xemplar/AlignedHistogramBucketExemplarReservoir.ts 92.30% <0.00%> (ø)
...sdk-metrics-base/src/exemplar/ExemplarReservoir.ts 95.65% <0.00%> (ø)

@srikanthccv srikanthccv marked this pull request as ready for review November 30, 2021 01:12
@srikanthccv srikanthccv requested a review from a team November 30, 2021 01:12
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just some nits

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nits

Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took so long, but LGTM thanks for the work

@dyladan dyladan added the enhancement New feature or request label Dec 28, 2021
@dyladan dyladan merged commit bef840b into open-telemetry:main Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants