-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk-metrics-base): bootstrap metrics exemplars #2641
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2641 +/- ##
==========================================
- Coverage 92.53% 92.52% -0.02%
==========================================
Files 144 151 +7
Lines 5186 5283 +97
Branches 1106 1116 +10
==========================================
+ Hits 4799 4888 +89
- Misses 387 395 +8
|
experimental/packages/opentelemetry-sdk-metrics-base/src/exemplar/NeverSampleExemplarFilter.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/exemplar/ExemplarReservoir.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/exemplar/ExemplarReservoir.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/exemplar/ExemplarReservoir.ts
Show resolved
Hide resolved
...tal/packages/opentelemetry-sdk-metrics-base/src/exemplar/SimpleFixedSizeExemplarReservoir.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/test/ExemplarFilter.test.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-api-metrics/src/types/Metric.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/exemplar/ExemplarReservoir.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, just some nits
experimental/packages/opentelemetry-sdk-metrics-base/src/exemplar/ExemplarReservoir.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/exemplar/ExemplarReservoir.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/exemplar/ExemplarReservoir.ts
Outdated
Show resolved
Hide resolved
...tal/packages/opentelemetry-sdk-metrics-base/src/exemplar/SimpleFixedSizeExemplarReservoir.ts
Outdated
Show resolved
Hide resolved
...tal/packages/opentelemetry-sdk-metrics-base/src/exemplar/SimpleFixedSizeExemplarReservoir.ts
Outdated
Show resolved
Hide resolved
...tal/packages/opentelemetry-sdk-metrics-base/src/exemplar/SimpleFixedSizeExemplarReservoir.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/exemplar/ExemplarReservoir.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/exemplar/ExemplarReservoir.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/exemplar/ExemplarReservoir.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/test/ExemplarReservoir.test.ts
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/exemplar/ExemplarReservoir.ts
Show resolved
Hide resolved
...tal/packages/opentelemetry-sdk-metrics-base/src/exemplar/SimpleFixedSizeExemplarReservoir.ts
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/exemplar/ExemplarReservoir.ts
Outdated
Show resolved
Hide resolved
...tal/packages/opentelemetry-sdk-metrics-base/src/exemplar/SimpleFixedSizeExemplarReservoir.ts
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/test/ExemplarReservoir.test.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % nits
...tal/packages/opentelemetry-sdk-metrics-base/src/exemplar/SimpleFixedSizeExemplarReservoir.ts
Outdated
Show resolved
Hide resolved
...kages/opentelemetry-sdk-metrics-base/src/exemplar/AlignedHistogramBucketExemplarReservoir.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/exemplar/Exemplar.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/exemplar/ExemplarFilter.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/exemplar/ExemplarReservoir.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this took so long, but LGTM thanks for the work
Short description of the changes
Part of #2594 . This adds the types, interfaces(
ExemplarFilter
,ExemplarReservoir
) and the built-in sdk implementations.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
npm test
Checklist: