Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preventing double enable for instrumentation that has been already enabled #2610

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

obecny
Copy link
Member

@obecny obecny commented Nov 9, 2021

Which problem is this PR solving?

preventing double enable for instrumentation that has been already enabled during startup based on default config value

@obecny obecny added the bug Something isn't working label Nov 9, 2021
@obecny obecny requested a review from a team November 9, 2021 22:40
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #2610 (6bd9871) into main (bc50c7b) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2610      +/-   ##
==========================================
+ Coverage   93.00%   93.04%   +0.04%     
==========================================
  Files         138      138              
  Lines        5092     5093       +1     
  Branches     1095     1096       +1     
==========================================
+ Hits         4736     4739       +3     
+ Misses        356      354       -2     
Impacted Files Coverage Δ
...entelemetry-instrumentation/src/autoLoaderUtils.ts 92.00% <0.00%> (+0.33%) ⬆️
...entelemetry-instrumentation/src/instrumentation.ts 77.77% <0.00%> (+7.40%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants