Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk-metrics-base): metrics name should be in the max length of 63 #2495

Merged
merged 5 commits into from
Oct 10, 2021

Conversation

legendecas
Copy link
Member

Which problem is this PR solving?

@legendecas legendecas requested a review from a team September 24, 2021 03:09
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #2495 (a06c9ae) into main (faca317) will increase coverage by 0.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2495      +/-   ##
==========================================
+ Coverage   92.89%   93.23%   +0.34%     
==========================================
  Files         127      137      +10     
  Lines        4376     5044     +668     
  Branches      930     1067     +137     
==========================================
+ Hits         4065     4703     +638     
- Misses        311      341      +30     
Impacted Files Coverage Δ
...ation-xml-http-request/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...mentation-xml-http-request/src/enums/EventNames.ts 100.00% <0.00%> (ø)
...kages/opentelemetry-exporter-otlp-http/src/util.ts 100.00% <0.00%> (ø)
...-instrumentation-fetch/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...emetry-instrumentation-xml-http-request/src/xhr.ts 97.58% <0.00%> (ø)
.../opentelemetry-exporter-otlp-http/src/transform.ts 88.69% <0.00%> (ø)
...lemetry-exporter-otlp-http/src/transformMetrics.ts 95.71% <0.00%> (ø)
...lemetry-exporter-otlp-http/src/OTLPExporterBase.ts 92.15% <0.00%> (ø)
...s/opentelemetry-instrumentation-fetch/src/fetch.ts 96.98% <0.00%> (ø)
...ages/opentelemetry-exporter-otlp-http/src/types.ts 100.00% <0.00%> (ø)

@vmarchaud vmarchaud requested a review from obecny October 9, 2021 13:58
@vmarchaud vmarchaud merged commit ed0ba06 into open-telemetry:main Oct 10, 2021
@vmarchaud vmarchaud added the bug Something isn't working label Oct 10, 2021
@legendecas legendecas deleted the metrics-ff/metric-name branch October 12, 2021 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants