-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: mark otlp exporters experimental #2490
chore: mark otlp exporters experimental #2490
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2490 +/- ##
==========================================
- Coverage 93.27% 93.25% -0.02%
==========================================
Files 125 137 +12
Lines 4445 5043 +598
Branches 931 1067 +136
==========================================
+ Hits 4146 4703 +557
- Misses 299 340 +41
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, there is some failure in karma config thats why the browser tests are failing, maybe path is not updated etc. ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, PR need rebase though
91bd7a0
to
4d9f5f2
Compare
QQ: Is OTel-js going to support OTLP export when the 1.0 is announced? |
@jsuereth we don't want to release the exporter as 1.0 while it depends on the unfinished metric api/sdk. we are moving it to experimental while the trace functionality is split out of it so the 1.0 is unblocked. the exporter with trace-only will be released as 1.0 when it is ready. |
This comment has been minimized.
This comment has been minimized.
@dyladan I guess I'm asking, as a user of OTel ecosystem, are we going to advertise users adopt 1.0 against the unstable receiver for OTEL or are we going to wait to advertise until the OTEL receiver is stable? Not trying to hold up this PR just wanted to understand the implications for when users ask about adopting Otel-JS |
I think it is fine to recommend users use the unstable otlp exporter as long as they understand that they will need to upgrade to the stable trace exporter in the near future. |
sounds good to me, given that the tracing portion of the exporter is "stable," and changing exporters doesn't create issues in the same way that breaking an API does. |
Per discussions in SIG mark the otlp exporters as unstable until the trace functionality is split from them.