Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: rename collector exporters #2476

Merged
merged 4 commits into from
Sep 15, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Sep 15, 2021

Rename collector exporters to otlp exporters.

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #2476 (09ede13) into main (745bd5c) will increase coverage by 0.71%.
The diff coverage is 100.00%.

❗ Current head 09ede13 differs from pull request most recent head 33baa00. Consider uploading reports for the commit 33baa00 to get more accurate results

@@            Coverage Diff             @@
##             main    #2476      +/-   ##
==========================================
+ Coverage   93.20%   93.91%   +0.71%     
==========================================
  Files         137       42      -95     
  Lines        5017     1348    -3669     
  Branches     1060      302     -758     
==========================================
- Hits         4676     1266    -3410     
+ Misses        341       82     -259     
Impacted Files Coverage Δ
...kages/opentelemetry-exporter-otlp-http/src/util.ts 100.00% <ø> (ø)
...lemetry-exporter-otlp-http/src/OTLPExporterBase.ts 92.15% <100.00%> (ø)
.../opentelemetry-exporter-otlp-http/src/transform.ts 88.69% <100.00%> (ø)
...lemetry-exporter-otlp-http/src/transformMetrics.ts 95.71% <100.00%> (ø)
...ages/opentelemetry-exporter-otlp-http/src/types.ts 100.00% <100.00%> (ø)
...s/opentelemetry-core/src/platform/node/sdk-info.ts 0.00% <0.00%> (-100.00%) ⬇️
...pentelemetry-core/src/platform/node/performance.ts 0.00% <0.00%> (-100.00%) ⬇️
...ckages/opentelemetry-exporter-zipkin/src/zipkin.ts 84.48% <0.00%> (-15.52%) ⬇️
...es/opentelemetry-instrumentation-grpc/src/utils.ts
...ckages/opentelemetry-sdk-metrics-base/src/types.ts
... and 93 more

@dyladan dyladan marked this pull request as ready for review September 15, 2021 15:52
@dyladan dyladan requested a review from a team September 15, 2021 15:52
@dyladan dyladan linked an issue Sep 15, 2021 that may be closed by this pull request
@dyladan dyladan mentioned this pull request Sep 15, 2021
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One blocking comment but looks good to me!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
packages/opentelemetry-exporter-otlp-grpc/test/helper.ts Outdated Show resolved Hide resolved
@dyladan
Copy link
Member Author

dyladan commented Sep 15, 2021

I updated it to change all exported types/variables from collector to otlp naming. Please take one more look for sanity before i merge.

Copy link
Contributor

@willarmiros willarmiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple readme comments!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename exporter-collector
6 participants