-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: rename collector exporters #2476
chore!: rename collector exporters #2476
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2476 +/- ##
==========================================
+ Coverage 93.20% 93.91% +0.71%
==========================================
Files 137 42 -95
Lines 5017 1348 -3669
Branches 1060 302 -758
==========================================
- Hits 4676 1266 -3410
+ Misses 341 82 -259
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One blocking comment but looks good to me!
packages/opentelemetry-exporter-otlp-http/test/node/CollectorMetricExporter.test.ts
Show resolved
Hide resolved
I updated it to change all exported types/variables from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple readme comments!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Rename collector exporters to otlp exporters.