Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk-trace): fix lint warnings #2446

Merged
merged 3 commits into from
Sep 4, 2021

Conversation

alisabzevari
Copy link
Contributor

related to #1093

Which problem is this PR solving?

  • This PR fixes lint warnings in sdk-trace-base and sdk-trace-node packages.

Short description of the changes

  • Fix lint warnings

@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #2446 (1aec686) into main (f810779) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2446      +/-   ##
==========================================
- Coverage   92.71%   92.69%   -0.03%     
==========================================
  Files         137      137              
  Lines        4996     4996              
  Branches     1057     1057              
==========================================
- Hits         4632     4631       -1     
- Misses        364      365       +1     
Impacted Files Coverage Δ
...elemetry-sdk-trace-base/src/BasicTracerProvider.ts 94.49% <100.00%> (ø)
packages/opentelemetry-sdk-trace-base/src/Span.ts 100.00% <100.00%> (ø)
...ackages/opentelemetry-sdk-trace-base/src/Tracer.ts 98.38% <100.00%> (ø)
...ackages/opentelemetry-sdk-trace-base/src/config.ts 86.84% <100.00%> (ø)
...-sdk-trace-base/src/export/InMemorySpanExporter.ts 100.00% <100.00%> (ø)
...ckages/opentelemetry-sdk-trace-base/src/utility.ts 100.00% <100.00%> (ø)
...telemetry-sdk-trace-node/src/NodeTracerProvider.ts 95.83% <100.00%> (ø)
...emetry-api-metrics/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@obecny obecny added the internal label Sep 3, 2021
@vmarchaud vmarchaud merged commit 63f6701 into open-telemetry:main Sep 4, 2021
@dyladan dyladan mentioned this pull request Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants