-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(website): support GH page links to canonical src #2421
docs(website): support GH page links to canonical src #2421
Conversation
That sounds great! Keeping the website docs up to date isn't a hard task, but it is one more thing that needs to be remembered and can be forgotten each time we update the docs. |
Hi all. Anything to be done before this can be approved and merged? |
We need another approver before we can merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The browser test failure is completely unrelated. I'm going to merge. |
Contributes to open-telemetry/opentelemetry.io#542
/cc @carlosalberto @mtwo @shelbyspees @austinlparker
While I can't (currently) show you a preview of this PR, you can see the corresponding change for OTel Java in action by clicking on the Edit this page and related links, from https://opentelemetry.io/docs/java/ and it's subpages.
@dyladan @obecny @vmarchaud: I see that this repo doesn't yet have a
docs-update
GitHub action. If you prefer, I can link OTel JSwebsite_docs
to the OTel website via a git submodule -- similar to what I did for Go in Link to OTel Go website_docs via submodule - open-telemetry/opentelemetry.io#690. That way you won't need to submit website_docs PRs.Context: #2051