Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move api into dependencies in integration tests #2385

Merged
merged 3 commits into from
Aug 4, 2021

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Jul 30, 2021

Integration tests require the OTel API. Therefore move it into dependencies section and remove the peer-dependency.

Integration tests require the OTel API. Therefore move it into dependencies section
and remove the peer-dependency.
@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #2385 (9127c96) into main (3b9cd16) will not change coverage.
The diff coverage is n/a.

❗ Current head 9127c96 differs from pull request most recent head 69a5ddc. Consider uploading reports for the commit 69a5ddc to get more accurate results

@@           Coverage Diff           @@
##             main    #2385   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files         145      145           
  Lines        5226     5226           
  Branches     1071     1071           
=======================================
  Hits         4849     4849           
  Misses        377      377           

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 1, 2021

CLA Signed

The committers are authorized under a signed CLA.

@Flarna Flarna closed this Aug 1, 2021
@Flarna Flarna reopened this Aug 1, 2021
@Flarna
Copy link
Member Author

Flarna commented Aug 1, 2021

EasyCLA tells I miss CLA authorization. No idea what I did that this got lost. If I click on above link to get authorized the result is an internal server error.

Any hints welcome...

@dyladan
Copy link
Member

dyladan commented Aug 2, 2021

I'm not sure what's wrong with the CLA check. I'll try to find out more

@dyladan
Copy link
Member

dyladan commented Aug 2, 2021

@Flarna looks like the email associated with that commit is a yahoo.de email. Most of your other commits appear to use the users.noreply.github.com email provided by github.

@dyladan
Copy link
Member

dyladan commented Aug 2, 2021

/easycla

@dyladan dyladan merged commit e1b3e98 into open-telemetry:main Aug 4, 2021
@Flarna Flarna deleted the int-tests-no-peer-dep branch August 4, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants