Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add node:16 to the test matrix #2244

Merged
merged 10 commits into from
Jun 8, 2021

Conversation

rauno56
Copy link
Member

@rauno56 rauno56 commented May 31, 2021

Which problem is this PR solving?

Adds current node version(16) to the test matrix.

@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #2244 (7934134) into main (d4df2f7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2244   +/-   ##
=======================================
  Coverage   92.79%   92.79%           
=======================================
  Files         144      144           
  Lines        5178     5178           
  Branches     1060     1060           
=======================================
  Hits         4805     4805           
  Misses        373      373           

@dyladan
Copy link
Member

dyladan commented Jun 1, 2021

Looks like node 16 uses an updated openssl which declares md certificates to be too weak for use. The certificates will need to be regenerated with a stronger algorithm than md5 in order to be accepted by node 16

@rauno56 rauno56 requested a review from MSNev as a code owner June 8, 2021 08:40
@rauno56
Copy link
Member Author

rauno56 commented Jun 8, 2021

I suspect that the remaining error with codecov has to do with credentials. I get the same error locally(no creds) and the http response of the upload request internally inside codecov package is "Could not determine repo and owner" which codecov mistakenly fails to recognize as a failure.

EDIT

Actually, after another look - it is supposed to switch to another API if that occurs but fails to do that. So that's a bug in teeny-request / codecov. codecov/codecov-node#284

@Flarna
Copy link
Member

Flarna commented Jun 8, 2021

I had a similar issue with codecov in another PR recently. It recovered in a rerun a day after.

Update: retriggered actions and new run was green

@dyladan
Copy link
Member

dyladan commented Jun 8, 2021

Their backend seems to be a little flaky sometimes

@dyladan dyladan merged commit 3d98420 into open-telemetry:main Jun 8, 2021
@@ -1,4 +1,4 @@
#! /bin/sh
#!/usr/bin/env sh
Copy link
Contributor

@MSNev MSNev Jun 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not everyone is going to have a local env.sh

@@ -1,4 +1,4 @@
#! /bin/sh
#!/usr/bin/env sh
Copy link
Contributor

@MSNev MSNev Jun 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above and later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants