-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add startActiveSpan method to Tracer #2221
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2221 +/- ##
==========================================
+ Coverage 92.29% 92.71% +0.41%
==========================================
Files 144 144
Lines 5168 5160 -8
Branches 1064 1056 -8
==========================================
+ Hits 4770 4784 +14
+ Misses 398 376 -22
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should fix your overload issues i think
869a3d2
to
47fd5f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it makes sense to add test in both the node sdk (which bundle the async hooks context manager) and the web (with the zone context manager)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did so far all necessary refactoring for the core repo with regards to api 0.20 just waiting for it to be released. I took exactly the same implementation that exists already in api for this function. Maybe I'm missing something but why it cannot be the same ?, your ts doc is much cooler than mine though :D. So curious why it needs to be different ?
Oh good point, I guess you. mean the implementation in noop tracer? Thats what I copy pasted originally here but @dyladan pointed out the preference for function overloads which I agree with, just could not get right in the api PR for the noop tracer implementation. As for the ts doc its the one I put in the tracer interface :) With that said, I think this implementation is better and can make a PR to api repo to overwrite the noop tracer implementation, wdyt? |
open-telemetry/opentelemetry-js-api#81 created to make implementation same |
dce2093
to
8ce4b40
Compare
2581011
to
19881b9
Compare
Signed-off-by: naseemkullah <naseem@transit.app>
Signed-off-by: naseemkullah <naseem@transit.app>
Signed-off-by: naseemkullah <naseem@transit.app>
Signed-off-by: naseemkullah <naseem@transit.app>
Signed-off-by: naseemkullah <naseem@transit.app>
Signed-off-by: naseemkullah <naseem@transit.app>
Signed-off-by: naseemkullah <naseem@transit.app>
Signed-off-by: naseemkullah <naseem@transit.app>
Signed-off-by: naseemkullah <naseem@transit.app>
Signed-off-by: naseemkullah <naseem@transit.app>
Signed-off-by: naseemkullah <naseem@transit.app>
Signed-off-by: naseemkullah <naseem@transit.app>
…textManager Signed-off-by: naseemkullah <naseem@transit.app>
2d2bc0e
to
1944b4e
Compare
…tActiveSpan Signed-off-by: naseemkullah <naseem@transit.app>
Signed-off-by: naseemkullah <naseem@transit.app>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great thanks
Np, thanks for the help! |
…sed to startActiveSpan Signed-off-by: naseemkullah <naseem@transit.app>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Which problem is this PR solving?
Short description of the changes