fix(opentelemetry-sdk-node): move nock to dev dependencies

[nflaig]

This PR moves nock from dependencies to devDependencies since the library is only required during development.

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Nico Flaig (774791b)

[johnbley]

Out of curiosity did you just happen to notice this or is there a tool that can produce a warning about this?

[codecov]

Codecov Report

Merging #2219 (9c9307a) into main (f13b35f) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 9c9307a differs from pull request most recent head 960e3c2. Consider uploading reports for the commit 960e3c2 to get more accurate results

@@            Coverage Diff             @@
##             main    #2219      +/-   ##
==========================================
- Coverage   92.71%   92.69%   -0.02%     
==========================================
  Files         142      142              
  Lines        5120     5120              
  Branches     1049     1049              
==========================================
- Hits         4747     4746       -1     
- Misses        373      374       +1     

Impacted Files	Coverage Δ
...emetry-core/src/platform/node/RandomIdGenerator.ts	87.50% <0.00%> (-6.25%)	⬇️

[nflaig]

@johnbley I happend to notice it while reviewing the code but npm-check could potentially be used to do this in an automated way, for example

cp packages/opentelemetry-sdk-node/package.json packages/opentelemetry-sdk-node/src/package.json
npm-check packages/opentelemetry-sdk-node/src --production
rm packages/opentelemetry-sdk-node/src/package.json

would produce the following

nock   😎  MAJOR UP  Major update available. https://github.com/nock/nock#readme
                    npm install --save nock@13.0.11 to go from 12.0.3 to 13.0.11
       😕  NOTUSED?  Still using nock?
                    Depcheck did not find code similar to require('nock') or import from 'nock'.
                    Check your code before removing as depcheck isn't able to foresee all ways dependencies can be used.
                    Use --skip-unused to skip this check.
                    To remove this package: npm uninstall --save nock

This does not seem to be the most robust solution I guess but it would have worked in this specific case.

[obecny]

lgtm, nice finding