-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: apply spec changes for TraceParams
#2190
Merged
vmarchaud
merged 10 commits into
open-telemetry:main
from
weyert:2139-rename-trace-params
May 13, 2021
Merged
feat: apply spec changes for TraceParams
#2190
vmarchaud
merged 10 commits into
open-telemetry:main
from
weyert:2139-rename-trace-params
May 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weyert
requested review from
dyladan,
Flarna,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
May 7, 2021 14:28
Codecov Report
@@ Coverage Diff @@
## main #2190 +/- ##
=======================================
Coverage 92.74% 92.74%
=======================================
Files 141 141
Lines 5087 5087
Branches 1045 1045
=======================================
Hits 4718 4718
Misses 369 369
|
obecny
reviewed
May 7, 2021
obecny
approved these changes
May 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
dyladan
approved these changes
May 11, 2021
vmarchaud
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes issue #2139
Short description of the changes
Breaking Change:
This pull requests renames the
TraceParams
toSpanLimits
and updates all references to this symbolThe properties of the
SpanLimits
have been changed to match the specification