Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply spec changes for TraceParams #2190

Merged
merged 10 commits into from
May 13, 2021

Conversation

weyert
Copy link
Contributor

@weyert weyert commented May 7, 2021

Which problem is this PR solving?

Fixes issue #2139

Short description of the changes

Breaking Change:
This pull requests renames the TraceParams to SpanLimits and updates all references to this symbol
The properties of the SpanLimits have been changed to match the specification

@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #2190 (0fc61ef) into main (6885278) will not change coverage.
The diff coverage is 88.88%.

@@           Coverage Diff           @@
##             main    #2190   +/-   ##
=======================================
  Coverage   92.74%   92.74%           
=======================================
  Files         141      141           
  Lines        5087     5087           
  Branches     1045     1045           
=======================================
  Hits         4718     4718           
  Misses        369      369           
Impacted Files Coverage Δ
packages/opentelemetry-tracing/src/config.ts 86.84% <ø> (ø)
packages/opentelemetry-sdk-node/src/sdk.ts 78.12% <50.00%> (ø)
packages/opentelemetry-tracing/src/Span.ts 98.07% <100.00%> (ø)
packages/opentelemetry-tracing/src/Tracer.ts 100.00% <100.00%> (ø)
packages/opentelemetry-tracing/src/utility.ts 100.00% <100.00%> (ø)

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

packages/opentelemetry-sdk-node/README.md Outdated Show resolved Hide resolved
@dyladan dyladan linked an issue May 12, 2021 that may be closed by this pull request
@vmarchaud vmarchaud merged commit 3f82ff4 into open-telemetry:main May 13, 2021
@weyert weyert deleted the 2139-rename-trace-params branch May 13, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename TracerParams to SpanLimits
5 participants