-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: prefer use of global TracerProvider/MeterProvider #2127
chore: prefer use of global TracerProvider/MeterProvider #2127
Conversation
Remove setting of TracerProvider in samples where it is actually not needed as the global TracerProvider should be prefered on default.
Codecov Report
@@ Coverage Diff @@
## main #2127 +/- ##
==========================================
+ Coverage 92.76% 93.87% +1.11%
==========================================
Files 140 70 -70
Lines 4987 3085 -1902
Branches 1029 676 -353
==========================================
- Hits 4626 2896 -1730
+ Misses 361 189 -172
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks this is something I've been meaning to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm,
Are you up to make the same in contrib, so we have unified examples ?
I added one more commit to align sequence of
Sure, will do once this landed. |
Remove setting of
TracerProvider
in samples where it is actually not needed as the globalTracerProvider
should be preferred on default.I found it also inconsistent to set a
TracerProvider
but noMeterProvider
.