Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zipkin): allow to configure url via environment #1675 #2097

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

vmarchaud
Copy link
Member

@codecov
Copy link

codecov bot commented Apr 11, 2021

Codecov Report

Merging #2097 (190d9be) into main (115ee39) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 190d9be differs from pull request most recent head f6018be. Consider uploading reports for the commit f6018be to get more accurate results

@@            Coverage Diff             @@
##             main    #2097      +/-   ##
==========================================
+ Coverage   92.73%   92.75%   +0.01%     
==========================================
  Files         138      138              
  Lines        4928     4927       -1     
  Branches     1017     1017              
==========================================
  Hits         4570     4570              
+ Misses        358      357       -1     
Impacted Files Coverage Δ
...ckages/opentelemetry-core/src/utils/environment.ts 100.00% <ø> (ø)
...ckages/opentelemetry-exporter-zipkin/src/zipkin.ts 100.00% <100.00%> (ø)
...emetry-core/src/platform/node/RandomIdGenerator.ts 93.75% <0.00%> (+6.25%) ⬆️

@dyladan dyladan added the enhancement New feature or request label Apr 12, 2021
@dyladan dyladan closed this Apr 13, 2021
@dyladan dyladan reopened this Apr 13, 2021
@dyladan
Copy link
Member

dyladan commented Apr 13, 2021

Don't mind the close and reopen. was an accident. there are conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants