-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: await http response in AWS EKS detector #2076
Conversation
* previously missing await on a promise response * update tests to reflect current behavior
|
Codecov Report
@@ Coverage Diff @@
## main #2076 +/- ##
==========================================
+ Coverage 92.72% 92.74% +0.01%
==========================================
Files 137 137
Lines 5048 5048
Branches 1054 1054
==========================================
+ Hits 4681 4682 +1
+ Misses 367 366 -1
|
/cc @KKelvinLo original package author /cc @willarmiros current AWS contact |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Which problem is this PR solving?
Short description of the changes
_isEks
in the detector, so the if block was never evaluating the result of the calldetect
wraps itself in a try/catch, and never throws