Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade API for patch release #2056

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Mar 30, 2021

This is the first step in fixing #2055

After this merges, we will need to release a new patch version. Then we will need to upgrade the API again and the next release should be a minor version bump (or RC)

@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #2056 (7ed2d18) into main (e369035) will decrease coverage by 0.30%.
The diff coverage is n/a.

❗ Current head 7ed2d18 differs from pull request most recent head 14ac627. Consider uploading reports for the commit 14ac627 to get more accurate results

@@            Coverage Diff             @@
##             main    #2056      +/-   ##
==========================================
- Coverage   93.05%   92.74%   -0.31%     
==========================================
  Files         153      149       -4     
  Lines        5972     5640     -332     
  Branches     1246     1187      -59     
==========================================
- Hits         5557     5231     -326     
+ Misses        415      409       -6     
Impacted Files Coverage Δ
...emetry-core/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️
...-instrumentation-fetch/src/enums/AttributeNames.ts
...emetry-instrumentation-xml-http-request/src/xhr.ts
...mentation-xml-http-request/src/enums/EventNames.ts
...s/opentelemetry-instrumentation-fetch/src/fetch.ts

@blumamir
Copy link
Member

Hi @dyladan
thanks for the fast PR to fix this issue.

Since our SDK is currently broken, we want to release an urgent fix so our clients will not experience crashes. We have two options:

  1. wait for this PR to merge, and for an updated v0.18.1 to be published to npm.
  2. release a fix for our SDK which depends on the current v0.18.1 with new api rc version. This option will break us again if the current v0.18.1 in npm will change.

Do you think the fix might be ready in the following hours?

@dyladan
Copy link
Member Author

dyladan commented Mar 30, 2021

Hi @dyladan
thanks for the fast PR to fix this issue.

Since our SDK is currently broken, we want to release an urgent fix so our clients will not experience crashes. We have two options:

  1. wait for this PR to merge, and for an updated v0.18.1 to be published to npm.
  2. release a fix for our SDK which depends on the current v0.18.1 with new api rc version. This option will break us again if the current v0.18.1 in npm will change.

Do you think the fix might be ready in the following hours?

yes i'm merging and releasing now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants