Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixing path of instrumentation file for different systems #1999

Merged
merged 2 commits into from
Mar 12, 2021

Conversation

obecny
Copy link
Member

@obecny obecny commented Mar 8, 2021

Which problem is this PR solving?

Short description of the changes

  • fixing path of instrumentation file for different systems

@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #1999 (e2bb863) into main (d6e9654) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1999      +/-   ##
==========================================
+ Coverage   92.92%   92.97%   +0.05%     
==========================================
  Files         152      152              
  Lines        5924     5925       +1     
  Branches     1245     1245              
==========================================
+ Hits         5505     5509       +4     
+ Misses        419      416       -3     
Impacted Files Coverage Δ
...src/platform/node/instrumentationNodeModuleFile.ts 100.00% <100.00%> (+80.00%) ⬆️
...emetry-core/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

Copy link
Member

@johnbley johnbley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, i think we should look into running tests on windows so we can catch issues like that later on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instrumentation doesn't handle relative path within modules OS independent
5 participants