Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding compatibility matrix for core and contrib versions #1920

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

obecny
Copy link
Member

@obecny obecny commented Feb 9, 2021

No description provided.

@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #1920 (2a48cd2) into main (dc38495) will increase coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1920      +/-   ##
==========================================
+ Coverage   92.30%   92.48%   +0.17%     
==========================================
  Files         157      171      +14     
  Lines        5122     5949     +827     
  Branches     1089     1262     +173     
==========================================
+ Hits         4728     5502     +774     
- Misses        394      447      +53     
Impacted Files Coverage Δ
...async-hooks/src/AsyncLocalStorageContextManager.ts 23.52% <0.00%> (-76.48%) ⬇️
...etry-exporter-prometheus/src/PrometheusExporter.ts 91.04% <0.00%> (-1.50%) ⬇️
...ges/opentelemetry-instrumentation-http/src/http.ts 94.69% <0.00%> (-0.82%) ⬇️
...kages/opentelemetry-node/src/NodeTracerProvider.ts
...kages/opentelemetry-exporter-collector/src/util.ts 100.00% <0.00%> (ø)
...s/opentelemetry-instrumentation-fetch/src/fetch.ts 99.23% <0.00%> (ø)
packages/opentelemetry-web/src/types.ts 100.00% <0.00%> (ø)
...ages/opentelemetry-exporter-collector/src/types.ts 100.00% <0.00%> (ø)
...kages/opentelemetry-web/src/StackContextManager.ts 97.05% <0.00%> (ø)
...ackages/opentelemetry-web/src/WebTracerProvider.ts 100.00% <0.00%> (ø)
... and 9 more

@dyladan
Copy link
Member

dyladan commented Feb 9, 2021

I think modules in the contrib repository should take a peer dependency on the core modules they depend on.

@dyladan dyladan merged commit 2395de6 into open-telemetry:main Feb 9, 2021
@obecny obecny deleted the matrix branch March 24, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants